-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Use the `tracing-syslog` crate and log to both stdout and syslog
Make the flag |
Let's reach out to @max-heller to see if he'd need a home for that crate (we could have it in liftedinit) or if he's planning to maintain it and publish it soon. It seems simple enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the change from stdout to stderr
…amework into fmorency/enh-101-syslog
Published as |
Make use of the
tracing-syslog
repo at https://github.com/max-heller/tracing-syslogSee tokio-rs/tracing#1137 for the whole story.
I tested this using
syslog-ng
. When thesyslog
service is not running, messages are still written to the log files and get picked up when the service restarts.Fixes #101
@hansl this crate is not on crates.io and this PR uses the git repo directly, fixed to a rev. I don't know the author's intention moving forward but we might want to fork this until/if it gets integrated into the
tokio
tracing ecosystem. WDYT?Also, this feature is currently not optional. Do you want me to add a
--syslog
flag to the binaries?