Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new argument --external #24

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: new argument --external #24

merged 1 commit into from
Apr 17, 2024

Conversation

shawnzhu
Copy link
Member

@shawnzhu shawnzhu commented Apr 17, 2024

Follow up of #21

So that it doesn't need to depend on a separate script all the time

it supports using --external multiple times.

@shawnzhu shawnzhu added the enhancement New feature or request label Apr 17, 2024
Copy link

@cmjarreau cmjarreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏 !

@shawnzhu shawnzhu merged commit 5eadbe5 into master Apr 17, 2024
4 checks passed
@shawnzhu shawnzhu deleted the support-external branch April 17, 2024 16:36
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Apr 17, 2024
@swain
Copy link
Contributor

swain commented Apr 17, 2024

@shawnzhu I was just about to put up this same PR -- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released Has been released to the package repository (NPM, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants