Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for escrow withdrawETH #272

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rkolpakov
Copy link
Contributor

Test shows holder perspective of withdrawing unstETH in RQ state

Copy link
Contributor

@Psirex Psirex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good showcase of withdrawal handling and the peculiarities of the getVetoerDetails() method! 👍🏻 Left a comment with a suggestion to improve the test’s clarity

Copy link
Contributor

@sandstone-ag sandstone-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the test - it covers an unobvious case. I suggest spending some effort into making the test easy to understand, for example, changing the naming of several variables and hiding complex parts in a helper methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants