Return to game if engine makes bad move #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an engine picks a bad move (i.e., illegal or invalid), then the game is aborted or the engine resigns. In either case, the program should return to the play_game() function to await the next message from lichess.
AttackingOrDefending
approved these changes
Dec 19, 2024
d51e5a4
into
lichess-bot-devs:master
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
If an engine picks a bad move (i.e., illegal or invalid), then the game is aborted or the engine resigns. In either case, the program should return to the play_game() function to await the next message from lichess.
Related Issues:
#1053. This may or may not fix the problem there, but it may lead to a more graceful shutdown of engines after an illegal/invalid move.
Checklist:
Screenshots/logs (if applicable):
N/A