Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for lib.lichess and lib.model #1051

Merged

Conversation

AttackingOrDefending
Copy link
Member

@AttackingOrDefending AttackingOrDefending commented Dec 2, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

Adds more tests. For testing lichess I use BadSunfish which is a bot that I created 3 years but didn't end up using.

Note: The lichess tests are skipped when the token is missing, which should happen on all PRs as they don't have access to environment variables.

Related Issues:

#920
More tests can still be added so I won't close it yet.

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

@AttackingOrDefending AttackingOrDefending merged commit 5359d3f into lichess-bot-devs:master Dec 5, 2024
23 checks passed
@AttackingOrDefending AttackingOrDefending deleted the more-tests branch December 5, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants