Fix running gradle and gradle source tests when gradle is unavailable #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creating the gradle runner tries to check the gradle version, which may not exist
jonabc
added a commit
that referenced
this pull request
Jan 6, 2023
## 4.0.1 ### Fixed - Running gradle tests will no longer fail when gradle is not available (#606)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #605
The gradle source's
enabled?check creates aGradle::Runnerobject to determine if a gradle executable is available. This can cause an order of operations where the source tries to use the executable before its existence has been check.Licensed::Sources::Gradle.enabled?calledgradle_runner.enabled?to check whether a gradle executable is availableLicensed::Sources::Gradle.gradle_runnercreates aLicensed::Sources::Gradle::RunnerobjectLicensed::Sources::Gradle::Runner#initializecallsLicensed::Sources::Gradle::Runner#create_init_scriptwhich creates an initialization script that is used when calling into licensedLicensed::Sources::Gradle::Runner.gradle_version, which tries to use a gradle executable. this is where the error is thrown, because the gradle executable isn't availableI fixed this by moving the runner's enabled and executable location logic into the source enumerator class so that it could be used without needing to create the init script. There are other ways to fix this but this was quick and I think it makes sense for the source to be responsible for determining whether a gradle executable exists and providing its path, if it exists, to the runner.
I also wrapped the tests in a check that enforces that
gradleis available when running the tests because a gradle executable is no longer shipped in licensed's test fixtures.