Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend overwrite of materialize to handle missing bundler specs #402

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Prepend overwrite of materialize to handle missing bundler specs #402

merged 1 commit into from
Sep 14, 2021

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Sep 13, 2021

This was found in an edge case where a separate override to __materialize__ was being used. The combination of the override and the alias/overwrite that exists before this change led to infinite recursion and a stacktoodeep error.

Having the logic fully overwrite the base method using prepend, and using super to call into the original behavior fixes this scenario.

@jonabc jonabc merged commit a7f897f into master Sep 14, 2021
@jonabc jonabc deleted the resolve-infinite-recursion branch September 14, 2021 15:41
jonabc added a commit that referenced this pull request Sep 14, 2021
@jonabc
release 3.2.3
27f22be 
## 3.2.3

2021-09-14

### Fixed

- Bundler source will no longer infinitely recurse when enumerating specifications (#402)
- Using the `--sources` command line option will no longer delete skipped sources' cached files (#401)
@jonabc jonabc mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonabc