Ensure ::Bundler.load is called before enumerating dependencies #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a no-op when bundler is already loaded
jonabc
added a commit
that referenced
this pull request
Sep 10, 2021
## 3.2.2 2021-09-09 ### Fixed - Bundler source works properly again when used outside of `bundle exec` (#397)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #396
The bug in the linked issue comes from installing licensed with
gem installrather than being listed in a Gemfile, and not running it throughbundle exec licensed. In that scenario::Bundler.loadwas never called and as a result::Bundler.configurewasn't either. In 3.2.0 and prior releases, this was accounted for in an equality check againstENV["BUNDLE_GEMFILE"]which would have been nil, triggering the configure call.As a fix, the source now always calls
::Bundler.loadbefore enumerating dependencies. The call is a no-op if the runtime is already loaded, so unless or until Bundler changes it's implementation this should be a safe change