Remove more custom bundler logic and reload the bundler runtime for each app #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes more custom logic from the bundler source, and relies more on bundler internals to the appropriate files There are two significant changes here 1. Using ::Bundler.load after ::Bundler.reset! reconfigures the local bundler runtime. This forces bundler to pick up any changes to the available platforms 2. Monkeypatching ::Bundler::Definition in order to remove as much custom logic as possible. As bundler changes, it's become increasingly brittle to use custom behaviors outside of how Bundler normally operates. This move is intended to focus the source more on configuring Bundler to operate over multiple directories similar to how Bundler configures RubyGems to operate over multiple projects.
|
Fixes it perfectly!! Thank you!! 😍 👍 |
jonabc
added a commit
that referenced
this pull request
Sep 6, 2021
## 3.2.1 2021-09-06 ### Changed - Updated multiple dependency versions (:tada: @mmorel-35 #385, #389) - Go homepage links use pkg.go.dev instead of godoc.org (:tada: @mmorel-35 73cfbbe) - Local development ruby version changed to 2.7.4 (#393) ### Fixed - Bundler source correctly finds platform specific dependencies (#392)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #362
This change primarily looks to fix the linked issue, which is done by reloading the bundler runtime with
::Bundler.loadafter resetting bundler's configuration with::Bundler.reset!. This should force bundler to look at the current directory's gem and lock files in determining things like available platforms.I found that with this change, Bundler acted like
licensedwas being run from the context of the project being evaluated. This allowed me to further pare down much of the custom logic that had been built up on the bundler source enumerator over time. The bundler source has been a love/hate relationship but I'm finding now that the best option usually involves not trying to override Bundler's behavior, or when necessary making very targeted functionality changes.This PR does include such changes, in that it monkey patches
::Bundler::Definition#specsand::Bundler::Definition.requested_groups. This simplifies the logic that had been built around managing which specs were or were not evaluated by licensed. With the monkey patch it's become easier to make targeted changes to behavior due to operating in the context of the definition object and having direct access to private methods