Do not reset bundler environment if unneeded #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonabc
added a commit
that referenced
this pull request
Jun 16, 2021
## 3.1.0 2021-06-16 ### Added - Licensed supports Swift/Swift package manager as a dependency source (:tada: @mattt #363)' ### Changed - The `source_path` configuration property accepts arrays of inclusion and exclusion glob patterns (#368) - The Nuget source now uses configured fallback folders to find dependencies that are not in found in the project folder (#366) - The Nuget source supports a configurable property for the path from the project source path to the project's `obj` folder (#365) ### Fixed - The Go source's checks for local packages will correctly find paths in case-insensitive file systems (#370) - The Bundler source will no longer unnecessarily reset the local Bundler environment configuration (#372)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix an edge case I saw in a project that uses a custom bundler and ruby build, where licensed was installed in a
Gemfileand run withbundle exec licensed .... In the target scenario, the bundler reset calls inwith_local_configurationwere causing the environment to no longer represent thebundle execenvironment, and platform-specific dependencies weren't being found.with_local_configurationis meant to support running licensed as a standalone tool outside ofbundle execwhere a bundler environment has already been loaded andENV["BUNDLE_GEMFILE"]should already be set to the expected gemfile path. The change checks whether the ENV var matches the expected local gemfile path, in which case the assumption is that the correct bundler environment is already loaded and the tool shouldn't reset anything.