Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuring source path globs that expand into a single directory #312

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Sep 24, 2020

closes #309

Two part fix to this change

  1. Better handle a missing source path in an app so that it doesn't crash the overall execution of licensed.
    • This will now log an error like No such directory <path>
  2. Better handling of path expansion
    • If the path specifies a directory that exists, don't expand
    • If the path expands into 0 paths, return the original configuration (which will be better handled with the first fix ☝️ )
    • For 1 or more expanded paths, use the existing value mapping that was previously used for 2 or more expanded paths.

@jonabc jonabc merged commit 7c8f0c3 into master Sep 24, 2020
@jonabc jonabc deleted the allow-single-src-expansion branch September 24, 2020 19:22
jonabc added a commit that referenced this pull request Oct 4, 2020
## 2.14.0
2020-10-04

### Addded
- `reviewed` dependencies can use glob pattern matching (#313)

### Fixed
- Fix configuring source path globs that expand into a single directory (#312)
@jonabc jonabc mentioned this pull request Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Source path glob patterns do not work for a single match
1 participant