Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate ruby 2.7 keyword arg warnings in cli #292

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

jurre
Copy link
Contributor

@jurre jurre commented Jul 6, 2020

Ruby 2.7 gives deprecation warnings for keyword arguments being passed as a hash.
This change removes a few of those warnings.

Ruby 2.7 gives deprecation warnings for keyword arguments being passed as a hash.
This change removes a few of those warnings.
Copy link
Contributor

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup 🙇

are there any other 2.7 kwarg warnings for licensed? I can check but if you already have that information... 😄

@jonabc jonabc merged commit 90107a5 into master Jul 6, 2020
@jonabc jonabc deleted the jurre/fix-2.7-kwarg-warning branch July 6, 2020 15:38
@jurre
Copy link
Contributor Author

jurre commented Jul 6, 2020

I don't think so, there are a few other warnings:

test/cli_test.rb:28: warning: assigned but unused variable - status
test/cli_test.rb:52: warning: assigned but unused variable - status
test/cli_test.rb:76: warning: assigned but unused variable - status
test/cli_test.rb:87: warning: assigned but unused variable - status

And a few warnings in gems:

licensee-9.14.0/lib/licensee/hash_helper.rb:16: warning: mismatched indentations at 'end' with 'else' at 14
licensee-9.14.0/lib/licensee/matchers/dice.rb:13: warning: mismatched indentations at 'end' with 'else' at 11
licensee-9.14.0/lib/licensee/license.rb:121: warning: method redefined; discarding old spdx_id
lib/ruby/2.7.0/forwardable.rb:226: warning: previous definition of spdx_id was here

I did have an issue locally WARNING: Nokogiri was built against LibXML version 2.9.10, but has dynamically loaded 2.9.4 that I didn't bother looking into 😬 so I might have missed something.

@jonabc
Copy link
Contributor

jonabc commented Jul 6, 2020

I don't think so, there are a few other warnings:

I've been fixing these as I find them, thanks for the heads up I'll fix those.

And a few warnings in gems:

👍 if/when those are fixed licensed can update references

I did have an issue locally WARNING: Nokogiri was built against LibXML version 2.9.10, but has dynamically loaded 2.9.4 that I didn't bother looking into 😬 so I might have missed something.

I think that error is dependent on the version of libxml you have installed locally and isn't directly related to the codebase 👍

@jurre
Copy link
Contributor Author

jurre commented Jul 6, 2020

I think that error is dependent on the version of libxml you have installed locally and isn't directly related to the codebase

Yeah that's just my local dev env 👍

jonabc added a commit that referenced this pull request Jul 7, 2020
## 2.12.2
2020-07-07

### Changed
- Cleaned up ruby 2.7 warnings (:tada: @jurre #292)
- Cleaned up additional warnings in tests (#293)
@jonabc jonabc mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants