Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to output NOTICE file #277

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Add command to output NOTICE file #277

merged 3 commits into from
Jun 2, 2020

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented May 29, 2020

This add a new command licensed notices, which outputs a NOTICE file for each configured application. I couldn't find a standard format for the file, so for now it looks like the following, and I'd welcome feedback if there is a preferred format.

THIRD PARTY NOTICES

*****
dependency@version

license text
-----
license text
-----
notice text
-----
notice text

*****
dependency@version
.....

Most of the work happens in the reporter, though it could arguably be done in the command as well 🤷

/cc @mlinksva @jeffmcaffer any opinions on the NOTICE file format?

@jonabc jonabc changed the title Add command to output notices file Add command to output NOTICE file May 29, 2020
@jonabc
Copy link
Contributor Author

jonabc commented Jun 1, 2020

any opinions on the NOTICE file format?

@mlinksva @jeffmcaffer ping 👋

@jeffmcaffer
Copy link

Not from me per se. As long as it meets legal terms and doesn't look completely horrible (it doesn't) then box checked!

should reference cache_path
@jonabc jonabc merged commit 5a5003f into master Jun 2, 2020
@jonabc jonabc deleted the generate-notices branch June 2, 2020 16:06
@jonabc jonabc mentioned this pull request Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants