Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipenv source #167

Merged
merged 6 commits into from
May 15, 2019
Merged

Pipenv source #167

merged 6 commits into from
May 15, 2019

Conversation

krzysztof-pawlik-gat
Copy link

Adding a simple source for pipenv -- nice wrapper around virtualenv and good, old pip.

This merge request contains one non-pipenv related change: a fix for reading & storing notice files that are not UTF-8 encoded.

This will solve issue #117.

jonabc
jonabc reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙇 Some questions mostly for my knowledge

@krzysztof-pawlik-gat
Copy link
Author

ghc/cabal test failed (due to timeout during ghc installation), I don't see a quick way of restarting the build on TravisCI (it may be my permissions thing). Can you restart the build? I'd like to avoid creating artificial commits just to trigger it.

jonabc
jonabc approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is 👍 after re-run. changes make sense, thank you for all the helpful information in comment responses 🙇

@jonabc jonabc merged commit 82d60b6 into licensee:master May 15, 2019
@krzysztof-pawlik-gat krzysztof-pawlik-gat deleted the pipenv-source branch May 16, 2019 05:25
This was referenced May 19, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonabc jonabc jonabc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysztof-pawlik-gat @jonabc