Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasapi: Force WIN_CoInitialize duing device open. #7489

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

icculus
Copy link
Collaborator

@icculus icculus commented Mar 17, 2023

(Putting this in a pull request so I can make sure it compiles on Windows.)

This lets background threads open a WASAPI audio device.

Note that this PR is for SDL2; for SDL3, we'll avoid the chance of a leak by managing this ourselves, since we're (hopefully) changing how device opens happen.

Fixes #7478.

Otherwise this won't work if you open a device on a background thread.

Fixes libsdl-org#7478.
@slouken slouken merged commit 446e094 into libsdl-org:SDL2 Mar 17, 2023
@icculus icculus deleted the sdl-wasapi-coinitialize-on-open branch March 17, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants