Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Fix DualSense Wireless Controller name #1144

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

davidhedlund
Copy link
Contributor

@davidhedlund davidhedlund commented Jul 14, 2024

  • Correct generated file name

….cfg

* Correct generated file name
* Manually added L2/R2 analog axes
@davidhedlund davidhedlund changed the title android/DualSense Wireless Controller.cfg android/DualSense Wireless Controller.cfg -- Added L2/R2 analog axes. Corrected file name Jul 14, 2024
Analog trigger don't  work in android (only udev)
@davidhedlund davidhedlund changed the title android/DualSense Wireless Controller.cfg -- Added L2/R2 analog axes. Corrected file name android/DualSense Wireless Controller.cfg -- Corrected file name Jul 18, 2024
@RobLoach RobLoach changed the title android/DualSense Wireless Controller.cfg -- Corrected file name android: Fix DualSense Wireless Controller name Jul 18, 2024
@RobLoach RobLoach merged commit 4fe7e2f into libretro:master Jul 18, 2024
1 check passed
@offalynne
Copy link
Contributor

The input_device field is incorrect and no longer matches after this change. This is a regression and should be reverted.

@davidhedlund
Copy link
Contributor Author

davidhedlund commented Aug 23, 2024

The input_device field is incorrect and no longer matches after this change. This is a regression and should be reverted.

How can you be certain about that?

In my experience, the name "DualSense Wireless Controller" appears when the DualSense is connected via Bluetooth to Android versions 10 through 13. Conversely, the name "Wireless Controller," as you suggest, is associated with the Sony DualShock 4 v2 when connected over Bluetooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants