Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake improvements #913

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Conversation

Marc-Aldorasi-Imprivata
Copy link
Contributor

check_required_components does not take a list of components; it takes the package name and determines if a component is available by checking the <package>_<component>_FOUND variable. Without this change, find_package(LibreSSL REQUIRED COMPONENTS Invalid) would succeed despite that component not existing.

This change also makes LIBRESSL_FOUND mirror the LibreSSL_FOUND variable that cmake uses internally to check if the package exists, and changes the install source paths of the cmake files to match the ones they were configured with.

busterb added a commit to busterb/portable that referenced this pull request Oct 2, 2023
@busterb
Copy link
Contributor

busterb commented Oct 29, 2023

Thanks for the PR @marc-groundctl

@busterb busterb self-assigned this Oct 29, 2023
@busterb busterb merged commit ce79c96 into libressl:master Oct 29, 2023
busterb added a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants