MSVC: Fixes from vcpkg #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea04ee7 to
348f843
Compare
busterb
added a commit
to busterb/portable
that referenced
this pull request
Oct 2, 2023
- Add `STDIN_FILENO` to compat unistd header. - Use quotes to include compat getopt header in the compat unistd. - Export additional symbols needed by ocspcheck (optarg, optind, ftruncate)
- Add `/Qspectre` to CFLAGS. - Silence C5045, it triggers whether `/Qspectre` is enabled or not.
348f843 to
42707bb
Compare
|
Hi, thanks for the PR. I think for now would like to leave the Spectre mitigation off by default, not because we don't want it, but it seems that the VS environment being built in needs to have additional libraries installed, and the check for version isn't sufficient to check for the libraries as well. |
|
I cherry-picked the oscpcheck fixes in c4bb6b7, thanks! Let's discuss the spectre mitigations in another PR. I'm not sure if we really want this to happen automatically or intentionally on behalf of the builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC currently has two patches for its LibreSSL port.
The first patch enables building
ocspcheckwith MSVC. This requires:getopt, which is already included inlibcrypto. Addingoptargandoptindto the DLL exports is necessary.ftruncate, which is already included inlibtls. Adding it to the DLL exports is necessary.STDIN_FILENOin theunistd.hcompat header.The second patch handles the Spectre vulnerability mitigation. The warning C5045 triggers whether
/Qspectreis used or not and warns about code that may be affected by this vulnerability.