-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink/Optimize Dockerfile #1430
Shrink/Optimize Dockerfile #1430
Conversation
I tested compiling the 4 target arches in the example in the Dockerfile from within the container after doing my modifications and it all succeeded so believe it's all good. |
I don't use Docker but sounds good to me! Would you resolve the conflict? |
The only comment I have is that to ensure it's still as easy as possible to comment lines out and just compile the platform you want. I think you got that with the new lines but I didn't check properly sorry. |
3ff23ee
to
be5d40e
Compare
Changes Shrink the resulting image with 70mb by removing un-used dependencies and merging several runs to a single layer.
be5d40e
to
c242ce5
Compare
@roderickvd Fixed the conflict (just a version bump for rust in rustup) @kingosticks It works exactly the same before, so no change in how you compile to specific platforms. |
Ok, great. |
Hi, anything more I can help out with to get this merged? |
Don't think so, as the others seem to be fine with these changes. I will probably merge it during the day. Could you maybe just quickly check if the docker images are still fine and report back? It seems we currently have some compilation issues on dev, so it would be nice to know if the images are impacted or not^^. (unrelated to the PR, but nice to know) |
Just checked myself. As |
Changes Shrink the resulting image with 70mb by removing unused dependencies and merging several
runs to a single layer.