Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink/Optimize Dockerfile #1430

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

tomodachi
Copy link
Contributor

Changes Shrink the resulting image with 70mb by removing unused dependencies and merging several
runs to a single layer.

@tomodachi
Copy link
Contributor Author

tomodachi commented Dec 21, 2024

I tested compiling the 4 target arches in the example in the Dockerfile from within the container after doing my modifications and it all succeeded so believe it's all good.

@roderickvd
Copy link
Member

I don't use Docker but sounds good to me! Would you resolve the conflict?

@kingosticks
Copy link
Contributor

The only comment I have is that to ensure it's still as easy as possible to comment lines out and just compile the platform you want. I think you got that with the new lines but I didn't check properly sorry.

@tomodachi tomodachi force-pushed the dockerfile_optimizing branch from 3ff23ee to be5d40e Compare December 25, 2024 15:50
Changes Shrink the resulting image with 70mb by removing
un-used dependencies and merging several
runs to a single layer.
@tomodachi tomodachi force-pushed the dockerfile_optimizing branch from be5d40e to c242ce5 Compare December 25, 2024 16:04
@tomodachi
Copy link
Contributor Author

@roderickvd Fixed the conflict (just a version bump for rust in rustup)

@kingosticks It works exactly the same before, so no change in how you compile to specific platforms.

@kingosticks
Copy link
Contributor

kingosticks commented Dec 25, 2024

Ok, great.

@tomodachi
Copy link
Contributor Author

Hi, anything more I can help out with to get this merged?

@photovoltex
Copy link
Member

Don't think so, as the others seem to be fine with these changes. I will probably merge it during the day.

Could you maybe just quickly check if the docker images are still fine and report back? It seems we currently have some compilation issues on dev, so it would be nice to know if the images are impacted or not^^. (unrelated to the PR, but nice to know)

@photovoltex
Copy link
Member

Just checked myself. As bindgen-cli and clang are getting installed the issue that occurs in the CI doesn't affect the image creation.

@photovoltex photovoltex merged commit 14e3965 into librespot-org:dev Jan 12, 2025
@tomodachi tomodachi deleted the dockerfile_optimizing branch January 14, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants