Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies sysinfo and RSA #1164

Merged
merged 5 commits into from
May 14, 2023

Conversation

yubiuser
Copy link
Contributor

@yubiuser yubiuser commented May 13, 2023

Updates dependencies to the latest version and regenerates Caro.lock.

librespot-core: /librespot/core/Cargo.toml
	rsa matches 0.8.2;	latest is 0.9.2
	sysinfo matches 0.28.4;	latest is 0.29.0

Relevant change was the removal of the PublicKey trait in RSA. It can be replaced by RsaPublicKey
See RustCrypto/RSA#300

Changelog for RAS: https://github.com/RustCrypto/RSA/blob/master/CHANGELOG.md
Changelog for sysinfo: https://github.com/GuillaumeGomez/sysinfo/blob/master/CHANGELOG.md

yubiuser added 4 commits May 13, 2023 11:54
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Contributor Author

yubiuser commented May 13, 2023

Needed to upgrade MSRV to 1.6.5

error: package `time-core v0.1.1` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0

@roderickvd
Copy link
Member

roderickvd commented May 14, 2023

Thanks. Don't you love it that those crypto crates change their API every release? This one isn't so bad, comparatively 😆

@roderickvd
Copy link
Member

Would you please update the changelog to mention the MSRV bump?

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Contributor Author

Don't you love it that those crypto crates change their API every release?

It's a pain :-D

Would you please update the changelog to mention the MSRV bump?

Done.

@roderickvd roderickvd merged commit c964102 into librespot-org:dev May 14, 2023
@yubiuser yubiuser deleted the update_dependencies branch May 14, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants