hack: ignore TLS hostname verification for spotifycdn.com #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore subdomains / hostpart name for everything under spotifycdn.com as those are (sometimes?) misconfigured. The cert must be for *.spotifycdn.com and the requested host must also be *.spotifycdn.com
05c6d95 to
3cc57b2
Compare
|
I've been testing this out today and while it prevents the cert failure, it seems that the chunk is often not available on the server name provided and throws a 404. We're really talking about audio4-gm-fb.spotifycdn.com which has been using the audio-gm-off.spotifycdn.com certificate, so this problem is possibly a little deeper in the spotify ecosystem. |
|
I think #779 is better solution, disable certificate verification is generally not a good idea and it seems to be broken anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotify seems to have misconfigured some of their hosts or TLS certs:
javax.net.ssl.SSLPeerUnverifiedException: Hostname audio4-gm-fb.spotifycdn.com not verified:
certificate: sha256/mikb4l8fq5rYJv+AdSiChROLrTKpCEENcVFH4engaDw=
DN: CN=audio-gm-off.spotifycdn.com
subjectAltNames: [audio-gm-off.spotifycdn.com]
This patch ignores the host / subdomain part if both the cert and the host we want to connect to end in spotifycdn.com.
This is a hack for misconfigured servers, but security implications should be close to zero.