This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Port tests to ES6. Use nock and sinon for better mocking / stubbing #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dd1566 to
b3a2f15
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is providing some updates to our test suite. Big changes:
api_mockin favor of mocks withnock. This allows us to simulate failures on a per test level and really customize how the Librato would respondsinonas a dep for stubs and spies and mocksstableand the LTS versionsHopefully, over time, we can make our test suite stronger and prevent small bugs from slipping through the cracks (such as #79)