This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Allow to disable hostname #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
072f542 to
9961ae9
Compare
|
Thanks for the PR! @mheffner can I get your +1 on this or thoughts? I'm not opposed to merging this. |
mheffner
approved these changes
Mar 2, 2017
lib/librato.js
Outdated
| // Set global measurement tags if they are defined. | ||
| if (config.librato.writeToLegacy && Object.keys(config.librato.writeToLegacy).length) { | ||
| // Write legacy metrics if enabled. | ||
| if (config.librato.writeToLegacy) { |
There was a problem hiding this comment.
@bryanmikaelian did we have a broken check here?
There was a problem hiding this comment.
Oh weird. The check is valid but it looks like the comment was wrong.
@johanneswuerbach Would you mind taking this out of your PR? I'll update the comment and verify everything is working in a separate PR.
There was a problem hiding this comment.
Sure, but the check seems wrong for a boolean value Object.keys(true).length === 0
This allows to disable sending a host tag by setting the host to false.
9961ae9 to
53fc3e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to disable sending a host tag by setting the host to
false.This helps in cases where statsd is not running on the same instance the tracked application is running.