Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to discover that browse terminates, closing the entries channel, after ~15 minutes. Clearly, there was logic present handling the stop/timeout case in the original code. A simple repro can be achieved using the example:
I changed it the way I think is most intuitive, which is not timeout at all. My use case is a long-running application and while I could certainly browse multiple times, I don't see why. It looks like legacy from the original repo. Timeouts can be handled the usual way, using
context.WithTimeout
, if required.