Fix: Correctly abort process on timeout #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+50
to
+51
| const { signal } = controller; | ||
| const { stdout, stderr } = await exec(`docker compose -f ${path.join(dir, "compose.yaml")} up ${upFlags.join(" ")}`, { signal }) |
There was a problem hiding this comment.
If exec needs an object that has a signal property, can't you just pass controller directly?
There was a problem hiding this comment.
This avoids passing in other things that are in the controller. This is also how you do it per the docs: https://nodejs.org/api/child_process.html#child_processexeccommand-options-callback
thomaseizinger
approved these changes
Apr 4, 2023
MarcoPolo
added a commit
to mxinden/test-plans
that referenced
this pull request
Apr 13, 2023
* Pass in abort controller signal * Rearrange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.