-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multistream-select 1.0: simultaneous open protocol extension #196
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
31b56bf
multistream simultaneous open protocol
vyzo df1ad98
address security protocol pipelining concerns
vyzo 15eb969
Update connections/simopen.md
vyzo 682894e
Update title
vyzo 21be08c
mandate base64 encoding for initiator selection integers
vyzo 26774a2
connections/simopen: Prefix fake protocol ID with a '/'
mxinden ff7a12e
Merge pull request #321 from mxinden/rfc/multistream-simopen-with-slash
Stebalien 3dd8877
connections/simopen: Add revision entry
mxinden debc8f5
connections/simopen: Use 64-bit instead of 256-bit nonce
mxinden dc663fe
connections/simopen: Send nonce in base-10 string representation
mxinden ae86e33
connections/simopen: Do not retry initiator selection
mxinden 13ea44a
connections/simopen: Clarify spec being for connection bootstrapping
mxinden 41ce779
connections/simopen: Add mxinden to interest group
mxinden 77cbb43
connections/README: Reference simultaneous open extension
mxinden dd14a1e
Merge branch 'libp2p/master' into rfc/multistream-simopen
mxinden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how should we encode this int? b64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, this needs to be encoded! Let's do base64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to mandate base64.