add identify/delta to identify spec #176
Conversation
|
Does this really need to be a separate protocol? I'm not seeing the need here aside from the concern about older peers breaking, in which case I feel like this should just become |
Librarian note: conversation continued in libp2p/go-libp2p#659 (comment) and onwards. |
| |------------------|-----------------------|------------------------------------------------| | ||
| | `identify` | `/ipfs/id/1.0.0` | Respond to queries for identifying info. | | ||
| | `identify/push` | `/ipfs/id/push/1.0.0` | Send info proactively to inform about changes. | | ||
| | `identify/delta` | `/p2p/id/delta/1.0.0` | Send partial updates to inform about changes. | |
There was a problem hiding this comment.
Is this not just "identify push 1.1.0"?
(either way works for me, this just feels like identify push with an extra feature)
Nvm. This part won't matter once we get signed peer addresses anyways. |
typo & whitespace thanks raul :) Co-Authored-By: Raúl Kripalani <raul.kripalani@gmail.com>
6f1b5e1 to
a01c265
Compare
|
Proposed change: https://github.com/libp2p/specs/pull/253/files |
|
@raulk @Stebalien what's the state of this PR? |
|
Given that this effort has stalled and given that go-libp2p removed support for identify delta (libp2p/go-libp2p#1975) I am closing here. Please comment in case you disagree with the direction. |
This updates the spec to track the changes @raulk is adding in libp2p/go-libp2p#659, which adds an
identify/deltavariant that only sends delta updates for protocol additions / removals (and maybe later, addresses). I'll keep this PR parked until the dust settles, but I figured I'd get a jump on it now.@raulk am I correct that identify/push now always sends full updates?