-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: public cbor/json codec module #5830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some suggestions and can you update Cargo.toml
in both request-response
and in the workspace? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Everything looks good @mosure! Only Cargo.lock updating left |
Description
follow-up to #5792
configuring a request_response behavior with generic codec does not allow for setting request/response size limits.
e.g. the following fails to compile since
request_response::cbor::codec
is private:Notes & open questions
Change checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature works