Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swarm): append missing changelog #5806

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

drHuangMHT
Copy link
Contributor

Description

Add missing changelog entry for #5242.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@drHuangMHT
Copy link
Contributor Author

I don't think other crates need a changelog entry because those are implementation details not exposed to users. cc @elenaf9 @jxs @dariusc93

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right! Completely missed this in the previous PR.
We should also add to the main libp2p crate

jxs
jxs previously approved these changes Jan 10, 2025
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
@jxs jxs marked this pull request as ready for review January 10, 2025 12:41
@jxs jxs added the send-it label Jan 10, 2025
@mergify mergify bot dismissed jxs’s stale review January 10, 2025 12:41

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit b3fcca8 into libp2p:master Jan 10, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants