chore: bump crate versions and update changelogs for #5676 #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10235b0 to
489993b
Compare
|
Hmm, when I update |
jxs
reviewed
Nov 20, 2024
jxs
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Hmm, when I update
libp2p-identityversion in rootCargo.toml, I got semver CI failure, when not, I got test identity CI failure, what should I do to bump the version of this crate?
Hi, yeah it's expected with libp2p-identity due to the way it is imported. See here for a CI that has run after libp2p-identity 0.2.10 was published.
Thanks!
|
published |
jxs
added a commit
to jxs/rust-libp2p
that referenced
this pull request
Jan 6, 2025
…p2p#5678) ## Description <!-- Please write a summary of your changes and why you made them. This section will appear as the commit message after merging. Please craft it accordingly. For a quick primer on good commit messages, check out this blog post: https://cbea.ms/git-commit/ Please include any relevant issues in here, for example: Related https://github.com/libp2p/rust-libp2p/issues/ABCD. Fixes https://github.com/libp2p/rust-libp2p/issues/XYZ. --> This PR bumps crate versions and add changelog entries for crates that are changed in libp2p#5676 Question: When should a crate version bump in the current release process? Should it be right before or right after publishing? I see most of current crate versions are published while some are not (e.g. libp2p-autonat@0.13.1 libp2p-gossisub@0.48.0 and libp2p-perf@0.4.0 etc.) ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR which don't need to go into the final commit message. --> ## Change checklist <!-- Please add a Changelog entry in the appropriate crates and bump the crate versions if needed. See <https://github.com/libp2p/rust-libp2p/blob/master/docs/release.md#development-between-releases>--> - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [x] A changelog entry has been made in the appropriate crates --------- Co-authored-by: João Oliveira <hello@jxs.pt> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
By switching from `void::Void` to `std::convert::Infallible`, #5676 changed the output types of some `NetworkBehavior` implementations in different protocols. This can cause a type mismatch for the user and therefore is a breaking change. #5678 (follow-up PR that version-bumped the crates affected by #5676) only bumped the patch version of the affected crates. The current PR now changes it to a minor version bump for all crates where types in a `NetworkBehavior` implementation were affected. It also reverts the version bump and CHANGELOG entry in `libp2p-quic` that was added with #5678, because that crate was never touched by the original PR. Pull-Request: #5811.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps crate versions and add changelog entries for crates that are changed in #5676
Question: When should a crate version bump in the current release process? Should it be right before or right after publishing? I see most of current crate versions are published while some are not (e.g. libp2p-autonat@0.13.1 libp2p-gossisub@0.48.0 and libp2p-perf@0.4.0 etc.)
Notes & open questions
Change checklist