Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gossispsub): deprecate futures-ticker #5674

Merged
merged 8 commits into from
Nov 21, 2024
Merged

chore(gossispsub): deprecate futures-ticker #5674

merged 8 commits into from
Nov 21, 2024

Conversation

jxs
Copy link
Member

@jxs jxs commented Nov 12, 2024

Description

to address RUSTSEC-2024-0384 . Use futures-timer and Delay instead

@jxs jxs marked this pull request as draft November 12, 2024 13:32
@jxs jxs force-pushed the deprecate-futures-ticker branch from 5692702 to 1ce8186 Compare November 12, 2024 14:00
@jxs jxs force-pushed the deprecate-futures-ticker branch from 1ce8186 to bd599ce Compare November 12, 2024 15:21
@jxs
Copy link
Member Author

jxs commented Nov 12, 2024

will also update if-watch and cut a new release to then update this Cargo.lock

@jxs jxs changed the title chore(gossispsub): deprecate future-ticker chore(gossispsub): deprecate futures-ticker Nov 12, 2024
@jxs jxs marked this pull request as ready for review November 12, 2024 16:57
dariusc93
dariusc93 reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to bump the version in Cargo.toml and update the CHANGELOG.md :)

@jxs jxs force-pushed the deprecate-futures-ticker branch from 6abe324 to 223a11a Compare November 18, 2024 18:37
@jxs jxs force-pushed the deprecate-futures-ticker branch from 223a11a to f276e62 Compare November 18, 2024 19:04
@jxs
Copy link
Member Author

jxs commented Nov 20, 2024

cargo deny is still failing due to rust-netlink/netlink-sys#24 (comment)

dariusc93
dariusc93 reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add futures-timer/wasm-bindgen to the wasm-bindgen feature?

@jxs
Copy link
Member Author

jxs commented Nov 21, 2024

futures-timer/wasm-bindgen

yup, thanks Darius, added!

@jxs jxs added the send-it label Nov 21, 2024
@mergify mergify bot merged commit c3a21d1 into libp2p:master Nov 21, 2024
70 of 71 checks passed
@ruseinov
Copy link

Thanks for making this happen! It would be great to see a release that contains this change sometime soon.

@jxs
Copy link
Member Author

jxs commented Nov 22, 2024

hi @ruseinov thanks for the interest! we plan to release a new version soon! We're waiting for #5595 to be merged and another one adding IDONTWANT support

@dariusc93 dariusc93 mentioned this pull request Jan 2, 2025
Open
jxs added a commit to jxs/rust-libp2p that referenced this pull request Jan 6, 2025
@jxs
chore(gossispsub): deprecate futures-ticker
6d6d24f 
to address [RUSTSEC-2024-0384 ](https://rustsec.org/advisories/RUSTSEC-2024-0384.html). Use `futures-timer` and `Delay` instead

Pull-Request: libp2p#5674.
@jxs jxs mentioned this pull request Jan 13, 2025
Closed
4 tasks
@jxs jxs mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@guillaumemichel guillaumemichel Awaiting requested review from guillaumemichel

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jxs @ruseinov @dariusc93 @guillaumemichel