-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow relay to forward unlimited bytes #5244
Conversation
Changelog entry will be added if the fix is accepted, discussion welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @drHuangMHT! LGTM just one nitpick. Can you also add a CHANGELOG.md
entry and Cargo.toml
update please?
cc @dariusc93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry, it's still missing the Cargo.toml
version bump
@jxs Need send-it lable and probably a re-approval to merge this |
Description
Allow relay to forward unlimited bytes from one peer to another by checking if
max_circuit_bytes
equals to 0 before checking ifbytes_sent
exceedsmax_circuit_bytes
.This will make current implementation follow the spec.
May close #5170.
Notes & open questions
Not sure how to write the test.
Change checklist