Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identify): add connection_id in event #4981

Merged
merged 5 commits into from
Jun 20, 2024
Merged

feat(identify): add connection_id in event #4981

merged 5 commits into from
Jun 20, 2024

Conversation

stormshield-frb
Copy link
Contributor

@stormshield-frb stormshield-frb commented Dec 5, 2023 •
edited by thomaseizinger
Loading

Description

Fixes: #4980.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@stormshield-frb stormshield-frb force-pushed the feat/add-connectionid-in-identify-event branch from dfca077 to 1a7599f Compare December 5, 2023 11:43
@thomaseizinger thomaseizinger added this to the v0.54.0 milestone Jan 15, 2024
@thomaseizinger
Copy link
Contributor

I'll set this to draft because it is a breaking change!

@thomaseizinger thomaseizinger marked this pull request as draft January 15, 2024 02:22
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2024

This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏

@dariusc93
Copy link
Member

@stormshield-frb could you update this PR?

@stormshield-frb stormshield-frb force-pushed the feat/add-connectionid-in-identify-event branch from 1a7599f to 79a2d58 Compare June 14, 2024 07:54
@stormshield-frb stormshield-frb marked this pull request as ready for review June 14, 2024 07:55
@stormshield-frb
Copy link
Contributor Author

I've updated the PR and fixed some of the checks but I cannot manage to find why the semver check is failing sorry :/

@dariusc93
Copy link
Member

That shouldnt be a blocker to the pr since it is happening in others too

guillaumemichel
guillaumemichel approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @jxs this one can also make it to the next release 👍🏻

jxs
jxs approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jxs jxs added the send-it label Jun 20, 2024
@mergify mergify bot merged commit 605f208 into libp2p:master Jun 20, 2024
71 of 72 checks passed
@stormshield-frb stormshield-frb deleted the feat/add-connectionid-in-identify-event branch August 28, 2024 09:43
TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this pull request Sep 14, 2024
@stormshield-frb @TimTinkers
feat(identify): add connection_id in event
c383a2d 
Fixes: libp2p#4980.

Pull-Request: libp2p#4981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumemichel guillaumemichel guillaumemichel approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.54.0
Development

Successfully merging this pull request may close these issues.

Add ConnectionId in Identify events
5 participants
@stormshield-frb @thomaseizinger @dariusc93 @jxs @guillaumemichel