Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(floodsub): use Bytes for FloodsubMessage::data #4754

Merged
merged 2 commits into from
Oct 29, 2023
Merged

fix(floodsub): use Bytes for FloodsubMessage::data #4754

merged 2 commits into from
Oct 29, 2023

Conversation

joshuef
Copy link
Contributor

@joshuef joshuef commented Oct 28, 2023 •
edited by thomaseizinger
Loading

Description

This should help avoid potentially costly clones.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@joshuef
fix(floodsub): convert data to Bytes.
5b21bcb 
This should help avoid potentially costly clones
thomaseizinger
thomaseizinger approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

protocols/floodsub/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title fix(floodsub): convert data to Bytes. fix(floodsub): use Bytes for FloodsubMessage::data Oct 29, 2023
@mergify mergify bot merged commit c8600cc into libp2p:master Oct 29, 2023
@thomaseizinger thomaseizinger mentioned this pull request Nov 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuef @thomaseizinger