Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(identify): remove deprecated symbols #4735

Merged
merged 8 commits into from
Oct 30, 2023
Merged

chore(identify): remove deprecated symbols #4735

merged 8 commits into from
Oct 30, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Oct 26, 2023
@thomaseizinger thomaseizinger mentioned this pull request Oct 27, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Oct 27, 2023
@thomaseizinger
Copy link
Contributor Author

thomaseizinger commented Oct 27, 2023 •
edited
Loading

Needs #4735 to fix kademlia tests.

@mxinden
Copy link
Member

mxinden commented Oct 30, 2023

Needs #4735 to fix kademlia tests.

😱 we are doomed. A recursive dependency.

@thomaseizinger
Copy link
Contributor Author

Needs #4735 to fix kademlia tests.

😱 we are doomed. A recursive dependency.

Hahaha. I meant #4743.

mergify bot pushed a commit that referenced this pull request Oct 30, 2023
@thomaseizinger
refactor(swarm-test): don't implicitly add external addresses
9bd127f 
This is a safer default than always adding the memory address as external. Kademlia for example depends on whether we have an external address.

Motivated-by: #4735.

Pull-Request: #4743.
@thomaseizinger
Copy link
Contributor Author

@mxinden I almost introduced a bug here where we waited for the interval initially before sending the first identify. I added a test to cover that.

@mergify mergify bot merged commit 3820a98 into master Oct 30, 2023
71 checks passed
@mergify mergify bot deleted the chore/identify-remove-deprecated branch October 30, 2023 23:59
@mxinden
Copy link
Member

mxinden commented Oct 31, 2023

@mxinden I almost introduced a bug here where we waited for the interval initially before sending the first identify. I added a test to cover that.

Much appreciated!

umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
@thomaseizinger
refactor(swarm-test): don't implicitly add external addresses
c6d87fc 
This is a safer default than always adding the memory address as external. Kademlia for example depends on whether we have an external address.

Motivated-by: libp2p#4735.

Pull-Request: libp2p#4743.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden