Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kad): deprecate Config::set_connection_idle_timeout #4675

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

leonzchang
Copy link
Contributor

@leonzchang leonzchang commented Oct 17, 2023

Description

Related: #3844.
Related: #4659.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@leonzchang leonzchang changed the title feat(kad): deprecate Config::set_connection_idle_timeout feat(kad): deprecate Config::set_connection_idle_timeout Oct 17, 2023
@leonzchang
Copy link
Contributor Author

fn on_connection_established(
&mut self,
ConnectionEstablished {
peer_id,
failed_addresses,
other_established,
..
}: ConnectionEstablished,
) {
for addr in failed_addresses {
self.address_failed(peer_id, addr);
}
// Peer's first connection.
if other_established == 0 {
self.connected_peers.insert(peer_id);
}
}

This may need to be changed when the #4659 (comment) is confirmed.

@leonzchang leonzchang marked this pull request as ready for review October 17, 2023 07:30
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the help!

@mergify mergify bot merged commit 411824a into libp2p:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants