Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rendezous): refresh registration on change to external addresses #4629

Merged
merged 14 commits into from
Oct 15, 2023
Merged

feat(rendezous): refresh registration on change to external addresses #4629

merged 14 commits into from
Oct 15, 2023

Conversation

dariusc93
Copy link
Member

@dariusc93 dariusc93 commented Oct 12, 2023 •
edited by thomaseizinger
Loading

Description

Resolves #4627.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title feat: Refresh registration upon a change in external addresses. feat(rendezous): refresh registration upon a change in external addresses Oct 13, 2023
thomaseizinger
thomaseizinger reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments!

protocols/rendezvous/CHANGELOG.md Outdated Show resolved Hide resolved
protocols/rendezvous/src/client.rs Outdated Show resolved Hide resolved
protocols/rendezvous/src/client.rs Outdated Show resolved Hide resolved
protocols/rendezvous/tests/rendezvous.rs Outdated Show resolved Hide resolved
protocols/rendezvous/tests/rendezvous.rs Outdated Show resolved Hide resolved
protocols/rendezvous/tests/rendezvous.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title feat(rendezous): refresh registration upon a change in external addresses feat(rendezous): refresh registration on change to external addresses Oct 13, 2023
@thomaseizinger thomaseizinger marked this pull request as ready for review October 15, 2023 08:39
@mergify mergify bot merged commit 4686ce8 into libp2p:master Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rendezvous: Refresh on external address changes
2 participants
@dariusc93 @thomaseizinger