Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dns): make {tokio,async_std}::Transport::custom infallible #4464

Merged
merged 11 commits into from
Oct 20, 2023
Merged

feat(dns): make {tokio,async_std}::Transport::custom infallible #4464

merged 11 commits into from
Oct 20, 2023

Conversation

p0mvn
Copy link
Contributor

@p0mvn p0mvn commented Sep 6, 2023 •
edited by thomaseizinger
Loading

Description

Resolves: #4462.

Notes & open questions

N/A

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@p0mvn p0mvn changed the title dns: make DnsConfig::custom infallible refactor: make DnsConfig::custom infallible Sep 6, 2023
thomaseizinger
thomaseizinger reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I am pretty sure this method is used in various places, can you adjust those too? I'd recommend using cargo clippy --all-features --all-targets to check.

transports/dns/CHANGELOG.md Outdated Show resolved Hide resolved
transports/dns/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title refactor: make DnsConfig::custom infallible feat(dns): make DnsConfig::custom constructor infallible Sep 7, 2023
@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Sep 7, 2023
@thomaseizinger
Copy link
Contributor

This is a breaking change so I am queuing it for the next milestone. FYI: We mark those as draft to not merge them accidentally!

@thomaseizinger thomaseizinger marked this pull request as draft September 7, 2023 02:27
@mxinden
Copy link
Member

mxinden commented Sep 7, 2023

Meta: very much appreciate the help here!

@p0mvn p0mvn requested a review from thomaseizinger September 8, 2023 01:29
thomaseizinger
thomaseizinger previously approved these changes Sep 8, 2023
View reviewed changes
transports/dns/CHANGELOG.md Outdated Show resolved Hide resolved
transports/dns/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger mentioned this pull request Oct 5, 2023
Closed
@thomaseizinger thomaseizinger marked this pull request as ready for review October 20, 2023 01:24
@thomaseizinger thomaseizinger changed the title feat(dns): make DnsConfig::custom constructor infallible feat(dns): make {tokio,async_std}::Transport::custom constructor infallible Oct 20, 2023
@mergify mergify bot dismissed thomaseizinger’s stale review October 20, 2023 01:26

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@thomaseizinger thomaseizinger changed the title feat(dns): make {tokio,async_std}::Transport::custom constructor infallible feat(dns): make {tokio,async_std}::Transport::custom infallible Oct 20, 2023
@mergify mergify bot merged commit 781405b into libp2p:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging this pull request may close these issues.

dns: make DnsConfig::custom infallible
3 participants
@p0mvn @thomaseizinger @mxinden