Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(swarm): fix stale docs around confirmed addresses #4135

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Discovered in #3954 (review).

Notes & open questions

cc @divagant-martian

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Jun 30, 2023
@drHuangMHT
Copy link
Contributor

Ping @thomaseizinger for a cancelled test blocking this PR from merging.

@thomaseizinger
Copy link
Contributor Author

Ping @thomaseizinger for a cancelled test blocking this PR from merging.

Thank you for the ping @drHuangMHT !

@mergify mergify bot merged commit 68e6bf9 into master Jul 1, 2023
@mergify mergify bot deleted the docs/external-address branch July 1, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants