Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): use cbor codec in file-sharing example #4036

Merged
merged 13 commits into from
Jun 6, 2023
Merged

feat(examples): use cbor codec in file-sharing example #4036

merged 13 commits into from
Jun 6, 2023

Conversation

tcoratger
Copy link
Contributor

Description

Remove the use of the core upgrade::transfer module in file-sharing example in favor of cbor codec.

Related #4011.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger
thomaseizinger reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's dogfood ALL the things! :)

examples/file-sharing/Cargo.toml Outdated Show resolved Hide resolved
examples/file-sharing/src/network.rs Outdated Show resolved Hide resolved
examples/file-sharing/src/network.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title feat(examples): Use cbor codec in file-sharing example feat(examples): use cbor codec in file-sharing example Jun 6, 2023
thomaseizinger
thomaseizinger reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

A few minor comments, plus have you tested that it still works?

examples/file-sharing/Cargo.toml Outdated Show resolved Hide resolved
examples/file-sharing/Cargo.toml Outdated Show resolved Hide resolved
examples/file-sharing/Cargo.toml Outdated Show resolved Hide resolved
examples/file-sharing/Cargo.toml Outdated Show resolved Hide resolved
examples/file-sharing/src/network.rs Outdated Show resolved Hide resolved
examples/file-sharing/Cargo.toml Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very clean, great to see the new features in action!

Let me know if you are up for resolving the final comment in this PR, otherwise we can also do this another time.

@tcoratger
Copy link
Contributor Author

Overall very clean, great to see the new features in action!

Let me know if you are up for resolving the final comment in this PR, otherwise we can also do this another time.

Should be ok now, tell me if something is wrong :)

thomaseizinger
thomaseizinger approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@mergify mergify bot merged commit 90d6a77 into libp2p:master Jun 6, 2023
@tcoratger tcoratger deleted the transfer-file-sharing branch June 7, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @thomaseizinger