-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(kad): remove deprecated module record
#4035
Conversation
Deprecated in libp2p#3738 Deprecation released with `v0.51.3`. Follow up to libp2p#3896 Part of libp2p#3647
@tcoratger an @thomaseizinger can you take a look here? |
Yeah, at the time we left this one because it is not obvious how to expose the record store etc so everything has nice names. I'd be okay to leave this one for later, perhaps open a dedicated issue about it. |
This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the interface is good enough.
@mxinden Still some Ci failures. |
Thanks! |
Description
Deprecated in #3738.
Follow up to #3896.
Part of #3647.
Notes & open questions
Change checklist