ci: reduce size of Rust interop-test image #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
May 15, 2023
|
@Mergifyio backport v0.48 v0.49 v0.50 v0.51 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2023
By using a multi-stage docker build, a distroless base image and a release build, we can get the size of the Rust interop test down to 50MB. Previously, the image would be around 500MB. A debug build image would still have ~400MB. The release build slows down our interop build step by about 1min 20s. That however is only because we don't currently seem to utilize the caches that from what I understand should work on self-hosted runners. I opted #3925 for that. Resolves: #3881. Pull-Request: #3926. (cherry picked from commit 0bc724a) # Conflicts: # interop-tests/Dockerfile
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2023
By using a multi-stage docker build, a distroless base image and a release build, we can get the size of the Rust interop test down to 50MB. Previously, the image would be around 500MB. A debug build image would still have ~400MB. The release build slows down our interop build step by about 1min 20s. That however is only because we don't currently seem to utilize the caches that from what I understand should work on self-hosted runners. I opted #3925 for that. Resolves: #3881. Pull-Request: #3926. (cherry picked from commit 0bc724a)
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2023
By using a multi-stage docker build, a distroless base image and a release build, we can get the size of the Rust interop test down to 50MB. Previously, the image would be around 500MB. A debug build image would still have ~400MB. The release build slows down our interop build step by about 1min 20s. That however is only because we don't currently seem to utilize the caches that from what I understand should work on self-hosted runners. I opted #3925 for that. Resolves: #3881. Pull-Request: #3926. (cherry picked from commit 0bc724a)
This was referenced May 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2023
By using a multi-stage docker build, a distroless base image and a release build, we can get the size of the Rust interop test down to 50MB. Previously, the image would be around 500MB. A debug build image would still have ~400MB. The release build slows down our interop build step by about 1min 20s. That however is only because we don't currently seem to utilize the caches that from what I understand should work on self-hosted runners. I opted #3925 for that. Resolves: #3881. Pull-Request: #3926. (cherry picked from commit 0bc724a)
This was referenced May 15, 2023
mergify bot
added a commit
that referenced
this pull request
May 15, 2023
This is an automatic backport of pull request #3926 done by [Mergify](https://mergify.com). Pull-Request: #3945.
mergify bot
added a commit
that referenced
this pull request
May 15, 2023
This is an automatic backport of pull request #3926 done by [Mergify](https://mergify.com). Pull-Request: #3944.
mergify bot
added a commit
that referenced
this pull request
May 15, 2023
This is an automatic backport of pull request #3926 done by [Mergify](https://mergify.com). Pull-Request: #3943.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By using a multi-stage docker build, a distroless base image and a release build, we can get the size of the Rust interop test down to 50MB. Previously, the image would be around 500MB. A debug build image would still have ~400MB. The release build slows down our interop build step by about 1min 20s. That however is only because we don't currently seem to utilize the caches that from what I understand should work on self-hosted runners. I opted #3925 for that.
Resolves: #3881.
Notes & open questions
Once this is merged, I'll backport it to the older releases and update the commit hashes that
libp2p/test-planspoints to.Change checklist