Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update policy on breaking changes and changelog entry format #3615

Merged
merged 3 commits into from
Mar 22, 2023
Merged

docs: update policy on breaking changes and changelog entry format #3615

merged 3 commits into from
Mar 22, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested a review from mxinden March 15, 2023 10:43
This was referenced Mar 15, 2023
Merged
Merged
Merged
jxs
jxs approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomaseizinger
thomaseizinger commented Mar 21, 2023
View reviewed changes
docs/release.md Outdated Show resolved Hide resolved
docs/release.md Outdated Show resolved Hide resolved
docs/release.md Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor Author

@mxinden friendly ping, this is the update of the docs requested in #3386 (comment).

mxinden
mxinden approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 3411b26 into master Mar 22, 2023
@mergify mergify bot deleted the update-release-docs branch March 22, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaseizinger @jxs @mxinden