Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Prepare v0.51.1 #3594

Merged
merged 1 commit into from
Mar 12, 2023
Merged

docs: Prepare v0.51.1 #3594

merged 1 commit into from
Mar 12, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Mar 12, 2023

No description provided.

@mxinden mxinden merged commit 3959b2c into libp2p:v0.51 Mar 12, 2023
@thomaseizinger
Copy link
Contributor

I think the tag naming changed with this release, previously we would have had a v0.51.1 tag. I am guessing that moving the crate to a sub-directory now causes this change in behaviour of cargo-release.

I did like the old behaviour though, can you add the other tag as well please?

@mxinden
Copy link
Member Author

mxinden commented Mar 13, 2023

I noticed this as well. Sorry for not pointing this out.

I did like the old behaviour though, can you add the other tag as well please?

I can. Do you feel strongly about it? The reason I haven't done it is that I don't think it is worth the additional step in our release process. I.e. I don't think a one-off git tag step is worth the v0.51.1 vs libp2p-v0.51.1 tag. Going one step further, given that we treat libp2p as just another crate in our workspace now, I think libp2p-v0.51.1 is even more consistent than v0.51.1. Also worth noting is that I am not aware of anyone depending on our previous v0.51.1 tag convention.

While we are at it, I had to force-push v0.51 branch. It diverged from master and from the v0.51.0 tag, with a single commit for automatic publish of interop tests. I don't think there is any downside to the force push.

@thomaseizinger
Copy link
Contributor

Do you feel strongly about it?

No, happy to roll with the more consistent approach.

umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants