Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Backport interop test to rust-libp2p v049 #3416

Merged
merged 9 commits into from
Feb 17, 2023
Merged

feat: Backport interop test to rust-libp2p v049 #3416

merged 9 commits into from
Feb 17, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Feb 1, 2023 •
edited
Loading

Description

Version 0.49.0 does not support QUIC, WebRTC and TLS so I have removed those from the JSON file. What this effectively does is that we "pretend" as if the ping test is now "rust-libp2p-head". Meaning if the interop tests pass on this PR, we should be good to go with releasing this as a docker container and supplying the JSON file we see here to the test-plans repository.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title Backport interop test to rust-libp2p v050 Backport interop test to rust-libp2p v049 Feb 1, 2023
@thomaseizinger thomaseizinger mentioned this pull request Feb 1, 2023
Closed
@thomaseizinger thomaseizinger changed the title Backport interop test to rust-libp2p v049 feat: Backport interop test to rust-libp2p v049 Feb 1, 2023
@thomaseizinger thomaseizinger changed the base branch from rust-v050-testplan to master February 1, 2023 03:15
jxs
jxs approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jxs jxs mentioned this pull request Feb 1, 2023
Closed
3 tasks
@thomaseizinger thomaseizinger changed the base branch from master to release/v0.49.0 February 8, 2023 09:12
@thomaseizinger thomaseizinger marked this pull request as ready for review February 8, 2023 09:21
@thomaseizinger thomaseizinger changed the base branch from release/v0.49.0 to v0.49 February 10, 2023 05:59
mergify bot and others added 4 commits February 10, 2023 18:49
@mergify @MarcoPolo
feat(interop-tests): build test binary inside container (backport #3441…
ea7836b 
…) (#3443)

Co-authored-by: Marco Munizaga <git@marcopolo.io>
@thomaseizinger
Fix conflicts
952ad1d
@thomaseizinger
Update lockfile
a4c0bcd
@mergify @thomaseizinger
docs(pnet): use backticks for referencing types (backport #3252) (#3450)
8e34424 
docs(pnet): use backticks for referencing types (#3252)

With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML. `<u8>` is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example.

(cherry picked from commit e960aab)

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
mxinden
mxinden reviewed Feb 13, 2023
View reviewed changes
@thomaseizinger thomaseizinger merged commit 582c840 into v0.49 Feb 17, 2023
@thomaseizinger thomaseizinger deleted the rust-v0490-testplan branch February 17, 2023 10:04
@mxinden
Copy link
Member

mxinden commented Feb 19, 2023

Great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@elenaf9 elenaf9 Awaiting requested review from elenaf9

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaseizinger @mxinden @jxs