fix(tcp): remove correct listener inTransport::remove_listener
#3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d41d6d3 to
f182108
Compare
libp2p_tcp::Transport::remove_listenerlibp2p_tcp::Transport::remove_listener
libp2p_tcp::Transport::remove_listenerTransport::remove_listener
f182108 to
fbec93f
Compare
|
Thanks for the speedy feedback @thomaseizinger! Updated the changelog with your suggestion and a PR link |
thomaseizinger
previously approved these changes
Jan 25, 2023
jsantell
added a commit
to subconsciousnetwork/noosphere
that referenced
this pull request
Jan 26, 2023
* Adds `server::APIServer`, a web server for local interaction of name system node. * Adds `server::HTTPClient` for interfacing with `server::APIServer`. * `NameSystemClient` trait introduced, implemented by both `NameSystem` `and server::HTTPClient`. * Uses my own fork of libp2p (0.51.0) with libp2p/rust-libp2p#3387 changes.
…e stored listeners.
fbec93f to
73c9636
Compare
Approvals have been dismissed because the PR was updated after the send-it label was applied.
thomaseizinger
previously approved these changes
Jan 26, 2023
|
@Mergifyio refresh |
✅ Pull request refreshed |
Approvals have been dismissed because the PR was updated after the send-it label was applied.
thomaseizinger
previously approved these changes
Jan 27, 2023
Approvals have been dismissed because the PR was updated after the send-it label was applied.
mxinden
approved these changes
Jan 27, 2023
|
I am planning to cut |
Thanks for the merge! |
jsantell
added a commit
to subconsciousnetwork/noosphere
that referenced
this pull request
Jan 27, 2023
* Adds `server::APIServer`, a web server for local interaction of name system node. * Adds `server::HTTPClient` for interfacing with `server::APIServer`. * `NameSystemClient` trait introduced, implemented by both `NameSystem` `and server::HTTPClient`. * Uses an interim version of libp2p (0.51.0) with libp2p/rust-libp2p#3387 changes, until the major 0.51.0 release.
cdata
pushed a commit
to subconsciousnetwork/noosphere
that referenced
this pull request
Jan 31, 2023
* Adds `server::APIServer`, a web server for local interaction of name system node. * Adds `server::HTTPClient` for interfacing with `server::APIServer`. * `NameSystemClient` trait introduced, implemented by both `NameSystem` `and server::HTTPClient`. * Uses an interim version of libp2p (0.51.0) with libp2p/rust-libp2p#3387 changes, until the major 0.51.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libp2p_tcp::Transport::remove_listenerpreviously removed the first listener that did not match the providedListenerId. This small fix brings it inline with other implementations.Change checklist