refactor(swarm): simplify DialOpts
#3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of carrying around an enum and parsing its contents later, directly set the correct values as we construct the final `DialOpts`.
4 tasks
4 tasks
mxinden
approved these changes
Jan 18, 2023
|
Given that this isn't super trivial, I'll wait for #3331 to be merged before sending this. |
jxs
approved these changes
Jan 19, 2023
|
Inrerop tests aren't required yet but are green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of tracking an inner enum, move all fields of
OptsintoDialOpts, setting them directly once we construct them. This makes the getters a lot simpler to implement and reduces code duplication.Notes
Helps with implementing #3328 (comment).
Draft until #3318 is merged because it is stacked on top of it.
Links to any relevant issues
Open Questions
Change checklist