fix(kad): Skip invalid multiaddr #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit `libp2p-kad` no longer discards the whole peer payload in case an addr is invalid, but instead logs the failure, skips the invalid multiaddr and parses the remaining payload. See libp2p#3244 for details.
thomaseizinger
approved these changes
Dec 23, 2022
protocols/kad/CHANGELOG.md
Outdated
Comment on lines
3
to
5
| - Skip invalid multiaddr in `Peer` `addrs`. See [PR XXX]. | ||
|
|
||
| [PR XXX]: https://github.com/libp2p/rust-libp2p/pull/XXX |
There was a problem hiding this comment.
Suggested change
| - Skip invalid multiaddr in `Peer` `addrs`. See [PR XXX]. | |
| [PR XXX]: https://github.com/libp2p/rust-libp2p/pull/XXX | |
| - Skip invalid multiaddr in `Peer` `addrs`. See [PR 3280]. | |
| [PR 3280]: https://github.com/libp2p/rust-libp2p/pull/3280 |
protocols/kad/src/protocol.rs
Outdated
| @@ -35,6 +35,7 @@ use futures::prelude::*; | |||
| use instant::Instant; | |||
| use libp2p_core::upgrade::{InboundUpgrade, OutboundUpgrade, UpgradeInfo}; | |||
| use libp2p_core::{Multiaddr, PeerId}; | |||
| use log::debug; | |||
There was a problem hiding this comment.
Personal preference only but I like not importing these because they often come and go with refactorings and log::debug is actually very expressive.
|
Mergify can backport PRs btw: https://docs.mergify.com/actions/backport/ It might interact oddly with our version bumping and changelog entries though. |
dignifiedquire
approved these changes
Dec 23, 2022
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
mxinden
commented
Dec 24, 2022
mxinden
commented
Dec 24, 2022
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Dec 26, 2022
With this commit `libp2p-kad` no longer discards the whole peer payload in case an addr is invalid, but instead logs the failure, skips the invalid multiaddr and parses the remaining payload. See libp2p#3244 for details. Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
4 tasks
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Jan 2, 2023
With this commit `libp2p-dcutr` no longer discards the whole remote payload in case an addr is unparsable, but instead logs the failure and skips the unparsable multiaddr. See libp2p#3244 for details.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this commit
libp2p-kadno longer discards the whole peer payload in case an addr is invalid, but instead logs the failure, skips the invalid multiaddr and parses the remaining payload.See #3244 for details.
Notes
Targets the
v0.50branch.Links to any relevant issues
Open Questions
Change checklist