refactor(autonat): buffer entire actions instead of events #3241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we used to buffer events separately and emit actions directly. That is unnecessary. We can have a single place where we return from the
poll
loop and shove all actions into the same buffer.Notes
I originally created this because I thought it would fix an issue where I needed to supply type hints as part of implementing #3240. That didn't turn out to be true but I still think that this change is a slight improvement. Feel free to close if you disagree :)
Links to any relevant issues
Open Questions
Change checklist