Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: Fix Identify protocol link in module doc. #3047

Merged
merged 1 commit into from
Oct 20, 2022
Merged

identify: Fix Identify protocol link in module doc. #3047

merged 1 commit into from
Oct 20, 2022

Conversation

jxs
Copy link
Member

@jxs jxs commented Oct 20, 2022

Description

The documentation is currently pointing to the deprecated type

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mxinden
mxinden approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden mxinden mentioned this pull request Oct 20, 2022
Closed
@mxinden
Copy link
Member

mxinden commented Oct 20, 2022

Ignoring the testground failure (libp2p/test-plans#59) and the semver failure (#2647).

@mxinden mxinden merged commit 4a4d4ad into libp2p:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxs @mxinden